-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support AWS ECR Public Container Registry #2549
Closed
jopemachine
wants to merge
10
commits into
topic/06-28-support_gitlab_container_registry
from
topic/07-24-feat_support_aws_ecr_container_registry
Closed
feat: Support AWS ECR Public Container Registry #2549
jopemachine
wants to merge
10
commits into
topic/06-28-support_gitlab_container_registry
from
topic/07-24-feat_support_aws_ecr_container_registry
+62
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jopemachine and the rest of your teammates on Graphite |
2 tasks
github-actions
bot
added
comp:manager
Related to Manager component
comp:agent
Related to Agent component
comp:common
Related to Common component
size:M
30~100 LoC
size:L
100~500 LoC
and removed
size:M
30~100 LoC
labels
Jul 24, 2024
github-actions
bot
added
type:feature
Add new features
size:M
30~100 LoC
area:docs
Documentations
size:L
100~500 LoC
and removed
size:L
100~500 LoC
size:M
30~100 LoC
labels
Jul 24, 2024
jopemachine
changed the title
feat: Support AWS ECR Container Registry
feat: Support AWS ECR Public Container Registry
Jul 25, 2024
jopemachine
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
July 25, 2024 08:21
5942be0
to
e25bf17
Compare
jopemachine
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
July 25, 2024 08:22
91d5c8a
to
406db99
Compare
2 tasks
jopemachine
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
July 26, 2024 03:08
e25bf17
to
a5dadb1
Compare
jopemachine
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
July 26, 2024 03:08
406db99
to
ef3a2dc
Compare
jopemachine
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
July 30, 2024 02:06
3dd31fc
to
1096da4
Compare
2 tasks
kyujin-cho
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
August 1, 2024 01:39
1194d1b
to
8994110
Compare
kyujin-cho
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
August 1, 2024 01:39
1096da4
to
0f9e791
Compare
kyujin-cho
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
August 1, 2024 03:07
8994110
to
79604b6
Compare
kyujin-cho
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
August 1, 2024 03:07
0f9e791
to
34b7bfa
Compare
jopemachine
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
August 1, 2024 04:55
79604b6
to
0fc60a8
Compare
jopemachine
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
August 1, 2024 04:55
34b7bfa
to
8877acc
Compare
kyujin-cho
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
August 1, 2024 05:34
0fc60a8
to
f254106
Compare
kyujin-cho
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
August 1, 2024 05:34
8877acc
to
3ee8326
Compare
kyujin-cho
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
August 1, 2024 05:41
f254106
to
5b5e659
Compare
kyujin-cho
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
August 1, 2024 05:41
3ee8326
to
7bd101f
Compare
kyujin-cho
requested changes
Aug 1, 2024
jopemachine
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
August 1, 2024 06:43
5b5e659
to
643e57e
Compare
jopemachine
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
August 1, 2024 06:43
7bd101f
to
c2da0ba
Compare
jopemachine
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
August 5, 2024 00:49
643e57e
to
e88690a
Compare
jopemachine
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
2 times, most recently
from
August 5, 2024 00:52
754cde8
to
dfbd5d0
Compare
jopemachine
force-pushed
the
topic/06-28-support_gitlab_container_registry
branch
from
August 5, 2024 00:57
bfcbdba
to
9ec3ff9
Compare
jopemachine
force-pushed
the
topic/07-24-feat_support_aws_ecr_container_registry
branch
from
August 5, 2024 00:58
dfbd5d0
to
e95013c
Compare
Closed as #1917 stack was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:agent
Related to Agent component
comp:common
Related to Common component
comp:manager
Related to Manager component
size:L
100~500 LoC
type:feature
Add new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #2337.
Test
ecr-public
Manually tested it using the following methods.
In this PR, the
cr.backend.ai/stable/python:3.9-ubuntu20.04
image is used as a placeholder for testing.Prerequisite
Create and configure the relevant users and policies appropriately through AWS IAM for testing this PR.
Then, generate the "access key" and store the
access_key
andsecret_access_key
in etcd.cr.backend.ai/stable/python
image to your AWS ECR package for testing.etcd
.container_registry
column of thegroups
table.public.ecr.aws
value toallowed_docker_registries
column ofdomains
table using below commandTest scenarios
Verify that the container registry added in this PR is functioning based on several scenarios.
If there are additional scenarios that need testing, please leave a comment.
1. Image Rescan
Image rescanning should work through the following command.
2. Create a session from the pulled image
Run a session using the downloaded image.
3. Commit the changes and push it to the container registry.
For committing a session, it is necessary to assume that the Registry alias is included in
config/docker/registry/public.ecr.aws/project
in etcd.Enter the key value using the following command.
Commit the changes using the
convert-to-image
command and push them to the container registry.Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2549.org.readthedocs.build/en/2549/
📚 Documentation preview 📚: https://sorna-ko--2549.org.readthedocs.build/ko/2549/